fix: adapt imports replacement with tsconfig outDir depth #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrisole
force-pushed
the
relative-paths-resolution
branch
from
667e81b to
18f4364
Compare
mgrisole
force-pushed
the
relative-paths-resolution
branch
from
18f4364 to
c5b171a
Compare
micalevisk
reviewed
Nov 15, 2023
| @@ -331,6 +334,24 @@ function isOptionalBoolean(text: string) { | |||
| return typeof text === 'string' && text === 'boolean | undefined'; | |||
| } | |||
|
|
|||
| function adaptPathWithConfig(inputPath: string) { | |||
| try { | |||
| const rawConfig = readFileSync('tsconfig.json', 'utf8'); | |||
There was a problem hiding this comment.
I'm concerned with this hard code "tsconfig.json"
As a dev, we can name our tsconfig file as we wish, so this readFile will always fail.
Not sure how to handle this properly
benjGam
approved these changes
May 29, 2024
|
@kamilmysliwiec why was this PR closed? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2706
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 2706
What is the new behavior?
This PR introduces a function
adaptPathWithConfigwhich translate theoutDirattribute from the user tsconfig.json config into a relative path prepending the previously resolved one fromreplaceImportPath.Does this PR introduce a breaking change?
Other information